Usage
https://github.com/Wodsoft/upf/blob/master/src/UniversalPresentationFramework.Platforms.Win32/Win32RendererD3D12Context.cs

These should be exposed by SkiaSharp: https://github.com/Wodsoft/upf/blob/master/src/UniversalPresentationFramework.Platforms.Win32/Win32RendererD3D12Context.cs#L291

@Gillibald How to update SkiaApi.generated.cs or it should be update manually?

I think I may have broken the merge with my merge of the Metal PR. Sorry. But, this PR is shaping up very well!

@Gillibald How to update SkiaApi.generated.cs or it should be update manually?

I think you found the generator in the utils directory. You should be able to just run this one on a Windows machine with VS installed: https://github.com/mono/SkiaSharp/blob/main/utils/generate.ps1

@mattleibow Yeah, I found it.

Many documents are out of date or missing. I spent a lot of date to look up how to modify codes.

Pipelines failed with Unable to find package Vortice.Direct3D12 and old feature tests. How to fix it?

ah, we have a mirror of all packages for reasons to prevent supply chain attacks. Let me mirror those packs.

increase 1,773,537 bytes compare to 3.0.0-preview2.1

@mattleibow Why android and macos test run failed?

@mattleibow Why android and macos test run failed?

I think there is a problem with the magic step that is supposed to use the correct build of skia. Just commit the submodule in this PR. Then the checkout of SkiaSharp will also pull the correct skia.

For the tests, I think this will work - still installing tooling as I have a new laptop: 6cf79ea

Hopefully it just works, I copied the context setup from the skia test files... seems simple enough, no idea.

For the tests, I think this will work - still installing tooling as I have a new laptop: 6cf79ea

Hopefully it just works, I copied the context setup from the skia test files... seems simple enough, no idea.

It's fail randomly I think. Sometime android failed and sometime macos failed or android and macos both failed.

ah, yeah sorry. Those are a bit flakey right now. Sometimes the Android emulator does not boot, or the macOS test runner crashes.

Maybe you can click Rerun failed jobs button to try for more times.

@Kation are you able to write some tests?

@mattleibow Workflow still report unauthorized.

Yeah, the public pool is a bit full, so I am using an internal one.

The build failed with the Nano Server checks saying there is no Direct3D available on Nano Server. I need to verify that, but for now I disabled D3D on Nano. So far, all the native builds looked green. Running again and the tests will tell us things hopefully.

The internal pipeline finished and was all green. So, I think we should be able to merge this soon.

I will give it another review and also try get the public builds working so folks can try out the artifacts.

I will happily be guinea pig!

/azp run

I will happily be guinea pig!

You should be able to download the nuget artifact from https://dev.azure.com/xamarin/public/_build/results?buildId=137303&view=results

Thanks for making those artifacts available! I'm afraid I hadn't looked too closely at the state of Skia's backend support and hadn't realized that the Ganesh set of backends included DX12 and not DX11. So, I was hoping that I could just rip out ANGLE and set up Skia contexts with DX11 instead. I don't think it should be a big deal to create a DX12 device and share the required textures/resources between the two, and probably still preferable to ANGLE for my usage. However, it'll take me a bit longer to spin something up with this than what I first thought...

OK, I've got a working proof of concept using the D3D backend. Took me a little while to check the performance. Looks about 5-10% faster than the ANGLE build for our app, and I'll get to drop a couple of dependencies once this gets merged/released. Nice work @Kation!

Very nice to hear! Are you able to share samples? I am no Direct-anything expert, so any samples will be great.

I am wanting to add more things to the views as well as make better samples showing different backends.

Hate to be that guy but have any other Direct3D C# binding libraries been considered. This Vortice.Direct3D12 seems to be a niche one. One example is Silk.NET which is under .NET Foundation umbrella (No affiliation on my side).

This is a good point. Thanks for making it here.

However, the main aim of this PR (for me) is to merge the base APIs that people can use. If you (or anyone) are familiar with Silk.NET, then feel free to open a PR or issue with some code I can add to the repo.

The way we are doing the nugets here is specifically to avoid a dependency lock-in, so the library specific code is in a separate nuget that can be deprecated/updated/changed at any time without breaking the core skia libraries. For example, to use Vortice, there will be a separate SkiaSharp.Direct3D.Vortice nuget that you would reference. There may be SkiaSharp.Direct3D.Silk.NET nuget in the future (if you open a PR 😉).

@mattleibow I'm not sure what value samples from my usage would add over the the unit tests that Kation added. I use different bindings, and most of the work I had to do was for D3D11/D3D12 interop, which I think is probably out of scope. D3D12 is a pretty complex beast - setting up Skia/SkiaSharp is the easy bit 😄 Suffice to say that I can create a GRContext and render to an SKSurface via GRBackendRenderTarget or GRBackendTexture just fine with this PR.

@maw136 FWIW regarding bindings, I didn't use the SkiaSharp.Direct3D.Vortice package, just the base GRD3DBackendContext/GRBackendRenderTarget/GRD3DTextureResourceInfo. Using Silk.NET, CsWin32 or any other bindings directly with them should be essentially trivial.

/azp run

OK, I think this PR is fianlly ready! Thanks for sticking with it for so long and everyone in the discussions.

Going to merge and will let everyone know when it is available on the preview feed - typically in 3 hours.

@mattleibow Pipeline still queue for running and report error, can we stop it?

The pipeline is finished and the version is 3.119.0-preview.0.20 on the preview feed.